Interop: use new target-clangxx for building C++ code
#35355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @hlopko @zoecarver |
zoecarver
approved these changes
Jan 12, 2021
|
Makes sense, thanks! Do you want to make c++11 the default? We wrote many tests assuming higher than that. |
|
@hlopko I think that C++11 is best to assume (that is the default target for the associated clang). I think that if we are testing a specific C++ version feature, we can always bump to a higher version individually. |
This enables control over the C++ flags used during testing for the C++ interop from a single location rather than having to alter all the tests.
compnerd
force-pushed
the
target-clangxx
branch
from
d1c3e7b to
9ba7bf7
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables control over the C++ flags used during testing for the C++
interop from a single location rather than having to alter all the
tests.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.