[build] Reenable lldb tests for macOS toolchain package #35357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shahmishal what's the right way to test this? Is it this? Or do I need to include "toolchain" too? |
|
@shahmishal friendly ping |
|
preset=buildbot_osx_package |
|
@swift-ci build toolchain macOS |
kastiglione
force-pushed
the
build-Reenable-lldb-tests-for-macOS-toolchain-package
branch
from
890bafe to
bb1f6ff
Compare
|
@swift-ci build toolchain macOS |
kastiglione
force-pushed
the
build-Reenable-lldb-tests-for-macOS-toolchain-package
branch
from
bb1f6ff to
85698e2
Compare
|
@swift-ci build toolchain macOS |
7 similar comments
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
@swift-ci build toolchain macOS |
|
There are three failures, I have a fix for one. For the other two, I think we could disable them, in order to re-enable this test and prevent regressions to the package build test. |
kastiglione
force-pushed
the
build-Reenable-lldb-tests-for-macOS-toolchain-package
branch
from
85698e2 to
64f83f5
Compare
|
@swift-ci build toolchain macOS |
|
@swift-ci smoke test |
adrian-prantl
approved these changes
May 2, 2023
kastiglione
deleted the
build-Reenable-lldb-tests-for-macOS-toolchain-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable lldb tests for package builds. The cause of the test failures have been fixed in the recent releases of lldb.
rdar://67820344