Skip to content

Interop: remove -O in test #35359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Interop: remove -O in test #35359

merged 1 commit into from
Jan 12, 2021

Conversation

compnerd
Copy link
Member

Now that the integral constants are being materialized when importing
constexpr from C++, we can avoid the need for the optimizer to inline
the value. Remove this workaround.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

Now that the integral constants are being materialized when importing
`constexpr` from C++, we can avoid the need for the optimizer to inline
the value.  Remove this workaround.
@compnerd
Copy link
Member Author

CC: @zoecarver @hlopko

@compnerd
Copy link
Member Author

@swift-ci please smoke test

Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hlopko
Copy link
Contributor

hlopko commented Jan 12, 2021

\o/ Thanks!

@compnerd compnerd merged commit d41c1be into swiftlang:main Jan 12, 2021
@compnerd compnerd deleted the constexpr-opt branch January 12, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants