CI: disable 4 tests, enable autodiff tests on Windows #35384
Conversation
This disables 4 tests: - DerivativeRegistrationTests.NonCanonicalizedGenericSignatureComparison - Reabstraction.diff param generic => concrete - Reabstraction.diff param and nondiff param generic => concrete - Reabstraction.result generic => concrete Simultaneously, enable the remainder of the auto-diff test suite on Windows. These tests fail on Windows due to an invalid parameter during the reabstraction of the generic differentiable parameters. The remainder of the auto-differentiation tests pass on all the platforms.
|
@swift-ci please test |
| @@ -217,6 +217,7 @@ DerivativeRegistrationTests.testWithLeakChecking("DerivativeGenericSignature") { | |||
| expectEqual(1000, dx) | |||
| } | |||
|
|
|||
| #if REQUIRES_SRxxxx | |||
There was a problem hiding this comment.
Rather than disabling on all platforms, could we disable only for the Windows platform? I know there's some controversy here that that may be an antipattern.
There was a problem hiding this comment.
We certainly could, though Im worried that there is a more delicate issue underlying these failures (it seems that the 4 failures are all caused by the same underlying cause related to casting). I think that @rxwei was interested in looking at the issue, but I figure that this helps get the tests running earlier rather than later.
There was a problem hiding this comment.
I'm pretty sure the issues are related to the SIL differentiable function representation and reabstraction: something related to TF-851. This issue isn't caught in SIL verification because @differentiable-function-type-related instruction verification is also disabled: TF-1197.
The nature of the issue is pretty well understood, it should be fixable when it becomes a P0 for someone (I don't foresee personally prioritizing it).
|
@swift-ci please test Windows platform |
|
Sure thing! Filed SR-14042. I also left a solution idea. Progress towards finally fixing reabstraction would be great! |
|
@swift-ci Please clean test Windows platform |
|
Spoke with @rxwei offline about this as well, I'll do a follow up to clean up the disabling to reference the SR, just so we can get the tests enabled earlier. |
This disables 4 tests:
Simultaneously, enable the remainder of the auto-diff test suite on
Windows. These tests fail on Windows due to an invalid parameter during
the reabstraction of the generic differentiable parameters. The
remainder of the auto-differentiation tests pass on all the platforms.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.