Skip to content

[5.4] Revert lazy children improvement in Swift Mirror #35393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

airspeedswift
Copy link
Member

@airspeedswift airspeedswift commented Jan 13, 2021

The improvements in #32041 inadvertently mean that custom mirrors's children no longer produce an AnyCollection that can be downcast to AnyRandomAccessCollection, which some users relied on being able to do. Reverting this change until that can be restored.

Resolves rdar://73061209

@airspeedswift airspeedswift requested a review from a team as a code owner January 13, 2021 00:16
@airspeedswift
Copy link
Member Author

@swift-ci please test

@airspeedswift airspeedswift merged commit 1e8cd99 into swiftlang:release/5.4 Jan 13, 2021
@airspeedswift airspeedswift deleted the 5.4-mirror-children branch January 15, 2021 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants