-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Enable ArrayPropertyOpt on OSSA #35396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meg-gupta
commented
Jan 13, 2021
- Add tests with array semantic calls having @guaranteed self
- Support copy_value as self value
- Support hoisting/copying self of array semantic calls in OSSA. This is common with Enable ArrayBoundsCheckElimination on OSSA #35380. And can be reviewed once in common for both PRs
@swift-ci test |
@swift-ci test source compatibility |
@swift-ci benchmark |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -OnoneCode size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relies on the same replaceAllUsesWithUndef fix as
#35380
But otherwise looks good.
6777fb7
to
2e586bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2e586bb
to
f6f5826
Compare
@swift-ci test and merge |