SIL: Fix type lowering of unowned reference to class-bound generic parameter [5.4] #35403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rameter Unowned references lower as address-only or loadable, depending on whether the underlying class type is known to be native Swift or not. In the case where we were lowering an interface type, we would unconditionally erase the type to AnyObject, producing an incorrect lowering when the generic signature constrained the type parameter to a native Swift class. Fixes <rdar://problem/73083179>.
|
@swift-ci Please test |
|
@jckarter Does this look OK for 5.4? |
slavapestov
changed the title
DougGregor
approved these changes
Jan 13, 2021
|
Build failed |
|
@swift-ci Please test Linux |
jckarter
approved these changes
Jan 13, 2021
AnthonyLatsis
added
swift 5.4
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unowned references lower as address-only or loadable, depending on
whether the underlying class type is known to be native Swift or
not.
In the case where we were lowering an interface type, we would
unconditionally erase the type to AnyObject, producing an incorrect
lowering when the generic signature constrained the type parameter
to a native Swift class.
Fixes rdar://problem/73083179.