Skip to content

SourceKit: avoid self-imports in generated Swift interfaces #35427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

egorzhdan
Copy link
Contributor

Generated Swift interfaces for modules with overlays, like Foundation or Dispatch, currently contain import Foundation/import Dispatch statements.

These imports are redundant, and this change removes them.

Generated Swift interfaces for modules with overlays, like Foundation or Dispatch, currently contain `import Foundation`/`import Dispatch` statements.

These imports are redundant, and this change removes them.
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

@akyrtzi since you are the author of this code fragment (2da311c) and listed as the code owner of IDE & SourceKit, maybe you could take a look at this change?

@akyrtzi akyrtzi requested a review from nathawes January 20, 2021 23:41
Copy link
Contributor

@nathawes nathawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@egorzhdan egorzhdan merged commit daa134f into swiftlang:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants