Skip to content

[TBDGen] Use effective linkage for class member async function pointers. #35437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2021
Merged

[TBDGen] Use effective linkage for class member async function pointers. #35437

merged 1 commit into from
Jan 20, 2021

Conversation

nate-chandler
Copy link
Contributor

Previously, the "bare" linkage of a link entity was used to determine whether to put an async function pointer into the tbd. That did not match the mechanism by which the linkage was determined in IRGen. There, the linkage is the "effective" linkage (i.e. the value returned from SILFunction::getEffectiveSymbolLinkage).

Here, whether to put the async function pointer corresponding to a class method is determined on the basis of that effective linkage.

rdar://problem/73203508

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9ec9fcab98516c933fbf0d46dca0b3cfd8affa7a

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - bbf127fadb1d84075778f75e2bf7261fafa69aed

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 55870ad2c2095d15619d084fcce1916dcfe79fd5

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9084607ba110c951924b72b395a475135c7febb1

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
[TBDGen] Use effective linkage for class member async function pointers.
2e880af 
Previously, the "bare" linkage of a link entity was used to determine
whether to put an async function pointer into the tbd.  That did not
match the mechanism by which the linkage was determined in IRGen.
There, the linkage is the "_effective_" linkage (i.e. the value returned
from SILFunction::getEffectiveSymbolLinkage).

Here, whether to put the async function pointer corresponding to a class
method is determined on the basis of that effective linkage.

rdar://problem/73203508
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2e880af

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macos platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 2e880af

@nate-chandler
Copy link
Contributor Author

@swift-ci please smoke test macos platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

ktoso
ktoso approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Seems this will fix a crasher I'm encountering, looks good though have not verified yet (would need to build a toolchain meh)

@nate-chandler nate-chandler merged commit 341a119 into swiftlang:main Jan 20, 2021
@nate-chandler nate-chandler deleted the rdar73203508 branch January 20, 2021 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nate-chandler @swift-ci @ktoso @DougGregor