[ConstraintSystem] NFC: Extract PotentialBinding(s) and auxiliary types/logic into separate header and namespace
#35453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es into a separate header Create a new namespace - `swift::constraints::inference` and associate `PotentialBinding` with it. This way it would be possible for constraint graph to operate on `PotentialBinding(s)` in the future.
…mp(...)` into cpp
…uct from `ConstraintSystem` This opens up a posibility of using `PotentialBindings` in `ConstraintGraphNode` and other places in `ConstraintGraph`.
…traint` into a method on `PotentialBindings`
|
@swift-ci please clean test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
@swift-ci please test macOS platform |
hborla
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift::constraints::inferencePotentialBinding(s)and auxiliary typesgetPotentialBindingFromRelationalConstraint,checkTypeOfBindingetc.This is a final step in preparation to storing bindings in constraint graph nodes to
avoid re-computation.