Skip to content

[NFC] Correct contributor’s name #35460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

beccadax
Copy link
Contributor

@brentdax is now @beccadax. More to come on this.

@beccadax
Copy link
Contributor Author

@swift-ci please smoke test and merge

@benrimmington
Copy link
Contributor

@beccadax I think you'll need to split this across multiple lines:

Becca Royal-Gordon <[email protected]> <[email protected]>
Becca Royal-Gordon <[email protected]> <[email protected]>
Becca Royal-Gordon <[email protected]> <[email protected]>
Becca Royal-Gordon <[email protected]> <[email protected]>

You can use the git check-mailmap command to verify each entry.

The canonical name and email address should be output for each of the following:

git check-mailmap '<[email protected]>'
git check-mailmap '<[email protected]>'
git check-mailmap '<[email protected]>'
git check-mailmap '<[email protected]>'

Currently, only the first succeeds, and the others just echo the command-line argument.

@beccadax
Copy link
Contributor Author

@benrimmington Strange—the docs say otherwise. Maybe it’s only in newer git versions or something.

@benrimmington
Copy link
Contributor

benrimmington commented Jan 18, 2021

@beccadax I couldn't find any documentation, other than git check-mailmap and git shortlog --email --summary.

The tool that generates https://swift.org/CONTRIBUTORS.txt may not support the more complex form (which allows two names, and two email addresses).

@lilyball
Copy link
Contributor

lilyball commented Feb 3, 2021

This does indeed need to be split. I can't find any docs that support doing multiple addresses like this, and the latest release (2.30.0) does not support it (not just git check-mailmap, but git shortlog is also showing old names/addresses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants