CrossModuleOptimization: fix crash when importing a module as implementationOnly #35472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntationOnly If a function uses a type imported as implementationOnly (or similar), it cannot be serialized. I added a new API in ModuleDecl (canBeUsedForCrossModuleOptimization), which performs this check. rdar://72864719
|
@swift-ci smoke test |
xymus
approved these changes
Jan 19, 2021
| ModuleDecl::ImportFilterKind::Exported, | ||
| ModuleDecl::ImportFilterKind::Default}; | ||
| SmallVector<ImportedModule, 4> results; | ||
| getImportedModules(results, filter); |
There was a problem hiding this comment.
You can also include ModuleDecl::ImportFilterKind::SPIAccessControl here, in this context they are just normal imports that includes more things. I think ShadowedByCrossImportOverlay should be safe too.
There was a problem hiding this comment.
ok, thanks. I'll let it as it is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function uses a type imported as implementationOnly (or similar), it cannot be serialized.
I added a new API in ModuleDecl (canBeUsedForCrossModuleOptimization), which performs this check.
https://bugs.swift.org/browse/SR-14006
rdar://72864719