LoadableByAddress: fix a crash related to single-element tuples containing a label and a closure. #35474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining a label and a closure. The canonical type was wrong for such tuples. https://bugs.swift.org/browse/SR-14046 rdar://73245321
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test |
|
Build failed |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical type was wrong for such tuples.
The problem here was that re-constructing a tuple-type from its element types is not good enough, because it is not preserving the tuple labels (and this makes a difference in type canonicalization). Instead, explicitly provide the resulting tuple type to SILBuilder.
https://bugs.swift.org/browse/SR-14046
rdar://73245321