[CodeCompletion][ASTPrinter] Fix a null pointer dereference in PrintAST #35508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumed that if the `Type CurrentType` member was set the `Decl *Current` member would be too. When printing the types rather than decls, like code completion does in CompletionLookup::addTypeAnnotation(), this doesn't always hold. Resolves https://bugs.swift.org/browse/SR-13703 Resolves rdar://problem/70057258
|
@swift-ci please test |
nathawes
deleted the
fix-printsingledepthofgenericsignature-completion-crash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumed that if the
Type CurrentTypemember was set theDecl *Currentmember would be too. When printing the types rather than decls (like code completion does in CompletionLookup::addTypeAnnotation()) this doesn't always hold.Resolves https://bugs.swift.org/browse/SR-13703
Resolves rdar://problem/70057258