[OSSA] Migrate AccessedStorage #35520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle begin_borrow -> convert_escape_to_noescape sequences.
Ignore end_borrow as a user of the access path. I don't think there's any value in viewing it as a use of the access path because we really care about address reads and writes in this context, not object lifetime extension. Treating it as an access path use clutters the analysis, and I'm afraid it will inhibit optimization.
|
@swift-ci test |
meg-gupta
approved these changes
Jan 20, 2021
| if (auto *beginBorrow = dyn_cast<BeginBorrowInst>(Callee)) { | ||
| Callee = beginBorrow->getOperand(); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
do we also need to handle copy_value here ?
There was a problem hiding this comment.
yes, we should handle copy_value. I added another commit to this PR.
|
Build failed |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of minor changes to the AccessedStorage utilities.
Handle begin_borrow->convert_escape_to_noescape
All tests that directly use the utilities are migrated.