Skip to content

[CodeCompletion][Sema] Don't filter out any viable solutions when solving for code completion #35535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2021
Merged

[CodeCompletion][Sema] Don't filter out any viable solutions when solving for code completion #35535

merged 1 commit into from
Feb 4, 2021

Conversation

nathawes
Copy link
Contributor

Resolves rdar://problem/73282163

@nathawes nathawes requested a review from xedin January 21, 2021 07:17
@nathawes
Copy link
Contributor Author

@swift-ci please test

xedin
xedin reviewed Jan 21, 2021
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the intention here but I'm worried that this might cause "too complex" issues within larger expressions because we'd get all of the partial solutions that have to be merged together so there is going to be a significant memory overhead... What would make me feel better if you could add a couple of examples of expressions with operators + code completion.

@nathawes nathawes force-pushed the dont-filter-out-non-best-solutions-for-completion branch 2 times, most recently from daf9d4f to 7d8b485 Compare January 22, 2021 04:46
@nathawes
Copy link
Contributor Author

@swift-ci please test

@nathawes nathawes requested a review from xedin January 22, 2021 04:47
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7d8b4858ea8ecb5ee0f7a41caa540655acab5210

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 7d8b4858ea8ecb5ee0f7a41caa540655acab5210

@nathawes
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 7d8b4858ea8ecb5ee0f7a41caa540655acab5210

@nathawes
Copy link
Contributor Author

nathawes commented Feb 2, 2021

@swift-ci please smoke test Linux

@nathawes
Copy link
Contributor Author

nathawes commented Feb 2, 2021

@swift-ci smoke test Linux

[CodeCompletion][Sema] Don't filter out any viable solutions when sol…
3fe0b8f 
…ving for code completion

Resolves rdar://problem/73282163
@nathawes nathawes force-pushed the dont-filter-out-non-best-solutions-for-completion branch from 7d8b485 to 3fe0b8f Compare February 3, 2021 02:36
@nathawes
Copy link
Contributor Author

nathawes commented Feb 3, 2021

@swift-ci please test and merge

3 similar comments
@nathawes
Copy link
Contributor Author

nathawes commented Feb 3, 2021

@swift-ci please test and merge

@nathawes
Copy link
Contributor Author

nathawes commented Feb 3, 2021

@swift-ci please test and merge

@nathawes
Copy link
Contributor Author

nathawes commented Feb 3, 2021

@swift-ci please test and merge

@nathawes
Copy link
Contributor Author

nathawes commented Feb 4, 2021

@swift-ci please smoke test Linux

@nathawes nathawes merged commit 7e65384 into swiftlang:main Feb 4, 2021
@nathawes nathawes deleted the dont-filter-out-non-best-solutions-for-completion branch February 4, 2021 04:41
@nathawes nathawes mentioned this pull request Feb 4, 2021
Merged
@ahoppen ahoppen mentioned this pull request Jul 28, 2021
Closed
@ahoppen ahoppen mentioned this pull request Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathawes @swift-ci @xedin