Update guide to mention correct subdirectory #35556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guide as written results in lots of repositories being placed as siblings to `swift-project`, instead of inside of it. This also results in the `build` directory being a sibling. Changing the clone to the `swift` directory fixes this.
CodaFi
reviewed
Jan 23, 2021
| @@ -68,15 +68,17 @@ toolchain as a one-off, there are a couple of differences: | |||
| If you plan on contributing regularly, cloning over SSH provides a better | |||
| experience. After you've [uploaded your SSH keys to GitHub][]: | |||
| ```sh | |||
| git clone [email protected]:apple/swift.git . | |||
| git clone [email protected]:apple/swift.git swift | |||
There was a problem hiding this comment.
The dot may be superfluous but it's not incorrect. I would leave it in.
There was a problem hiding this comment.
The dot is what makes it incorrect. Unless we change to the swift directory first.
|
Just one nit. Thanks! |
|
Should we instead revert 565385b? It seems like that PR and this PR are both changing the same thing. 🤔 |
|
Yes, it seems 565385b is what broke it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guide as written results in lots of repositories being placed as siblings to
swift-project, instead of inside of it. This also results in thebuilddirectory being a sibling. Changing the clone to theswiftdirectory fixes this.