[android][test] Mark concurrency test with REQUIRES. #35557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concurrency tests needs requires, so platforms that have not yet enabled concurrency do not fail on them. The Android CI machines were failing since the introduction of these test. Introduced in swiftlang#35544.
|
@swift-ci please smoke test |
rintaro
approved these changes
Jan 22, 2021
|
FWIW the failure in https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android/8965 has been fixed by #35555 . But |
|
Oh. That makes more sense. I will close this one without merging, but feel free to add that requires if you think it is worth it. The commit message here is not very factual any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concurrency tests needs requires, so platforms that have not yet
enabled concurrency do not fail on them.
The Android CI machines were failing since the introduction of these
test. Introduced in #35544.