[ownership] cd7c9e97e46a0141e37f10fbfb74c094e0576ff3 followups #35563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
We were using std::next on the pointer, not the iterator meaning we were accessing bad memory.
|
@swift-ci smoke test |
gottesmm
deleted the
pr-cd7c9e97e46a0141e37f10fbfb74c094e0576ff3-followups
branch
atrick
reviewed
Jan 23, 2021
| auto *valInsertPt = val->getDefiningInsertionPoint(); | ||
| if (!valInsertPt) | ||
| auto *nextInsertPt = val->getNextInstruction(); | ||
| if (!nextInsertPt) |
There was a problem hiding this comment.
I actually don't think we should ever bailout after getNextInstruction. Can't we just assert in side getNextInstruction that it isn't called on a terminator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes stuff from #35522.