Skip to content

Revert "[Concurrency] isCanceled spelling to follow guidance" #35564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jan 22, 2021

Reverts #35549

@ktoso
Copy link
Contributor Author

ktoso commented Jan 22, 2021

@swift-ci please smoke test

@ktoso ktoso requested a review from DougGregor January 22, 2021 22:30
@ktoso ktoso merged commit ad33889 into main Jan 23, 2021
@ktoso ktoso deleted the revert-35549-wip-task-canceled-spelling branch January 23, 2021 03:37
@xwu
Copy link
Collaborator

xwu commented Jan 30, 2021

@ktoso Out of curiosity, how come this change didn't work out?

@ktoso
Copy link
Contributor Author

ktoso commented Jan 31, 2021

Ongoing spelling discussions and @DougGregor had a strong opinion here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants