Skip to content

OSSA ownership optimization RAUW utility fixes. #35571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2021

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Jan 23, 2021

Verify that the OwnershipRAUWUtility always preserves the original
borrow scope by exhaustively switching over OperandOwnership.

And related cleanup.

@atrick atrick requested a review from gottesmm January 23, 2021 04:56
@atrick
Copy link
Contributor Author

atrick commented Jan 23, 2021

@gottesmm just need to get this cleanup and self-checking in place to I can proceed to add functionality. I haven't self-reviewed or tested it yet

@atrick
Copy link
Contributor Author

atrick commented Jan 23, 2021

@swift-ci test

@atrick atrick force-pushed the fix-rauw-borrowuse branch 2 times, most recently from b8a7338 to 02f6fab Compare January 24, 2021 01:39
@atrick
Copy link
Contributor Author

atrick commented Jan 24, 2021

@swift-ci smoke test

Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments/thoughts. Overall looks good!

Verify that the OwnershipRAUWUtility always preserves the original
borrow scope by exhaustively switching over OperandOwnership.

And related cleanup.
@atrick atrick force-pushed the fix-rauw-borrowuse branch from 02f6fab to a2fac95 Compare January 24, 2021 02:17
@atrick
Copy link
Contributor Author

atrick commented Jan 24, 2021

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit f7f658c into swiftlang:main Jan 24, 2021
@atrick atrick deleted the fix-rauw-borrowuse branch October 19, 2022 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants