Concurrency: attempt to handle Windows draining #35577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than just simply invoking abort on Windows, attempt to load dispatch and execute the main loop by looking up `dispatch_main` in the module. Assuming that dispatch was used already, the `LoadLibraryW` will provide the handle to the module currently mapped in. This still is not correct, since we do not link to libdispatch, so we cannot have invoked any dispatch queuing methods. However, this is better than the previous behaviour of simply aborting. This resolves the symptom in SR-14086, but not the underlying problem.
|
CC: @etcwilde |
|
@swift-ci please smoke test |
|
Does CoreFoundation compile/work for Windows? If yes, could we match the Mac/Linux behaviour and check for |
|
CoreFoundation does build/work on Windows. However, we do not have a build of CoreFoundation handy. That is actually a bug in the implementation for non-Darwin platforms (I have another patch for that I will be putting up). The CoreFoundation implementation in Foundation is not meant to be used outside of Foundation (as per @millenomi). And you're welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just simply invoking abort on Windows, attempt to load
dispatch and execute the main loop by looking up
dispatch_mainin themodule. Assuming that dispatch was used already, the
LoadLibraryWwill provide the handle to the module currently mapped in. This still
is not correct, since we do not link to libdispatch, so we cannot have
invoked any dispatch queuing methods. However, this is better than the
previous behaviour of simply aborting.
This resolves the symptom in SR-14086, but not the underlying problem.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.