Concurrency: avoid CFRunLoopRun on non-Darwin
#35585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CoreFoundation implementation on non-Darwin platforms included in Foundation is not meant to be used as a general purpose CoreFoundation implementation. Since non-Darwin targets do not default to providing a CoreFoundation implementation, we should generally assume that the symbol is not present. This changes the non-Darwin paths to always use `dispatch_main` rather than `CFRunLoopRun`.
|
CC: @etcwilde |
|
@swift-ci please test |
|
CC: @millenomi |
|
cc @phausler — will this compromise anything because of the different entry point? |
|
Build failed |
|
This seems reasonable to me, there are some sneaky side effects here to consider.
I would like to see a unified approach for all platforms but sadly I don't think we can avoid calling the CF API. |
|
@swift-ci please smoke test macOS platform |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoreFoundation implementation on non-Darwin platforms included in
Foundation is not meant to be used as a general purpose CoreFoundation
implementation. Since non-Darwin targets do not default to providing a
CoreFoundation implementation, we should generally assume that the
symbol is not present. This changes the non-Darwin paths to always use
dispatch_mainrather thanCFRunLoopRun.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.