[stdlib] Generalize array bridge/cast machinery #3560
Merged
+97
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test and merge |
| struct UnwrapFailure : Error {} | ||
| extension Optional { | ||
| internal func unwrappedOrError() throws -> Wrapped { | ||
| if self == nil { throw UnwrapFailure() } |
There was a problem hiding this comment.
Why not
guard let unwrapped = self else { thrown UnwrapFailure() }
return unwrapped... avoiding unsafe APIs.
|
Sweet! @rjmccall has most of the type checker changes in place, IIRC |
dabrahams
force-pushed
the
id-as-any-stdlib
branch
2 times, most recently
from
f09c294 to
46be0fc
Compare
Now we support casting and bridging to/from [Any], not just [AnyObject] Note that the typechecker still doesn't allow all the casts we'd like; see the FIXMEs in test/1_stdlib/ArrayBridge.swift.gyb.
dabrahams
force-pushed
the
id-as-any-stdlib
branch
from
46be0fc to
6821aca
Compare
|
@swift-ci Please test and merge |
kateinoigakukun
pushed a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we support casting and bridging to/from [Any], not just [AnyObject]
Note that the typechecker still doesn't allow all the casts we'd like;
see the FIXMEs in test/1_stdlib/ArrayBridge.swift.gyb.