Skip to content

[Async CC] Make error indirect. #35603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

[Async CC] Make error indirect. #35603

merged 1 commit into from
Feb 16, 2021

Conversation

nate-chandler
Copy link
Contributor

Previously, the error stored in the async context was of type SwiftError *. In order to enable the context to be callee released, make it indirect and change its type to SwiftError **.

rdar://71378532

@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch 2 times, most recently from 13e284b to 23a5ea6 Compare January 27, 2021 00:55
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 23a5ea69bedd8ceff6534aa820ab1e9d776c6908

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 23a5ea69bedd8ceff6534aa820ab1e9d776c6908

@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch from 23a5ea6 to e840997 Compare February 11, 2021 15:40
@nate-chandler nate-chandler marked this pull request as ready for review February 11, 2021 15:40
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e84099773ac6c82787be42949ef7cac585ea12f4

@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch from e840997 to dbc7916 Compare February 11, 2021 17:09
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e84099773ac6c82787be42949ef7cac585ea12f4

@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch 3 times, most recently from f52197a to c6f469d Compare February 11, 2021 17:53
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch from c6f469d to 3d0d51d Compare February 11, 2021 18:45
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3d0d51d96719a703c8540f956a83cddd43f60ec1

@nate-chandler
[Async CC] Make error indirect.
e2a8abc 
Previously, the error stored in the async context was of type SwiftError
*.  In order to enable the context to be callee released, make it
indirect and change its type to SwiftError **.

rdar://71378532
@nate-chandler nate-chandler force-pushed the concurrency/irgen/rdar71378532 branch from 3d0d51d to e2a8abc Compare February 11, 2021 19:35
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e2a8abc

@nate-chandler
Copy link
Contributor Author

Please test with following pull request:
swiftlang/llvm-project#2486

@swift-ci Please test linux platform

aschwaighofer
aschwaighofer approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e2a8abc

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e2a8abc

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please asan test

@nate-chandler
Copy link
Contributor Author

ASAN failures are the same as those on main.

@nate-chandler nate-chandler merged commit de63a23 into swiftlang:main Feb 16, 2021
@nate-chandler nate-chandler deleted the concurrency/irgen/rdar71378532 branch February 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschwaighofer aschwaighofer aschwaighofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nate-chandler @swift-ci @aschwaighofer