Skip to content

[AST] Adjust TypeBase::getTypeVariables to accept a set #35607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Jan 27, 2021

Currently the pattern is to collect the type variables and then unique
them. Instead of asking clients to do uniquing, let's just accept a set
as an argument.

@xedin xedin requested a review from hborla January 27, 2021 02:12
Currently the pattern is to collect the type variables and then unique
them. Instead of asking clients to do uniquing, let's just accept a set
as an argument.
@xedin xedin force-pushed the type-vars-accepts-set branch from 9a908ff to b03dc63 Compare January 27, 2021 02:13
@xedin
Copy link
Contributor Author

xedin commented Jan 27, 2021

@swift-ci please test

@xedin
Copy link
Contributor Author

xedin commented Jan 27, 2021

@swift-ci please test source compatibility

@xedin
Copy link
Contributor Author

xedin commented Jan 27, 2021

@swift-ci please test source compatibility debug

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@xedin
Copy link
Contributor Author

xedin commented Jan 27, 2021

Debug suite failed with UPASS on swift-futures project.

@xedin xedin merged commit fda3dc5 into swiftlang:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants