Diagnostics: improve error message at attr diagnosis failure #35634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to just crash:
> Assertion failed: (loc.isValid() && "Diagnosing attribute with invalid
location"), function diagnoseAndRemoveAttr
but now includes at least information what attribute caused the crash:
> Attribute '@actorIndependent ' has invalid location, failed to
diagnose!
Assertion failed: (false && "Diagnosing attribute with invalid
location"), function diagnoseAndRemoveAttr
|
This can show up when synthesized code interacts with attributes, e.g. when a protocol synthesized code implements has an attribute, and a note is issued about it |
|
@swift-ci please smoke test |
|
Eh, this is alright by me |
kavon
requested changes
Jan 29, 2021
|
Thanks @kavon, applied the ifndef. |
|
@swift-ci please test |
kavon
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to just crash:
but now includes at least information what attribute caused the crash:
This way at least we know what attr caused the crash right away and I would have wasted less hours chasing the completely wrong thing 😉