[Sema] fix ParenPattern resolution when subexpression is a NilLiteralExpr #3564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
changed the title
|
Thanks, LGTM. @swift-ci please test and merge. |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
A minor fix to the
ResolvePatternASTVisitor used in TypeCheckPattern.cpp.Previously, if a ParenExpr's subexpression returned nullptr when passed to
visit()(which happens fornilliterals, sincevisitNilLiteralExpr()isn't defined), thenvisitParenExpr()itself would return nullptr, so the ParenExpr was just wrapped in an ExprPattern. This broke the ability ofcoercePatternToType()to peek at the ExprPattern's expression and convertNilLiteralExprto anEnumElementPattern, because instead of finding a NilLiteralExpr, it'd just find the ParenExpr.With this fix,
visitParenExpr()reuses existing logic fromgetSubExprPattern(), which wraps the subexpression in an ExprPattern, even when there's no special visitor for it, rather than wrapping the whole ParenExpr in an ExprPattern.Resolved bug number: SR-2066
"Parenthesized nil in a case statement breaks exhaustivity checking" filed by @gregomni
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.