cmake: fix Xcode project generation to include all header files. #35647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by commit cf1f240. This commit reverts the 2 lines which broke the inclusion of header files in the generated Xcode project.
|
@swift-ci smoke test and merge |
compnerd
reviewed
Jan 29, 2021
| get_filename_component(dir ${CMAKE_CURRENT_SOURCE_DIR} DIRECTORY) | ||
|
|
||
| string(REGEX MATCHALL "/[^/]+" split_path ${CMAKE_CURRENT_SOURCE_DIR}) | ||
| list(GET split_path -1 dir) |
There was a problem hiding this comment.
Hmm, I'm not sure I understand how this differs. Is this not getting the basename of the current source dir?
There was a problem hiding this comment.
Yes, but the wrong code did get the directory.
Sorry, I didn't spent too much time on it - I just reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by commit cf1f240.
This commit reverts the 2 lines which broke the inclusion of header files in the generated Xcode project.