[AutoDiff] Fix TBDGen issues for derivative dispatch thunks and method descriptors. #35667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
dan-zheng
approved these changes
Jan 30, 2021
joshnewnham
approved these changes
Jan 30, 2021
|
@swift-ci please test and merge |
|
Build failed |
|
Build failed |
rxwei
force-pushed
the
more-ad-thunks
branch
2 times, most recently
from
cec24e6 to
03fd95e
Compare
…d descriptors. - Add `DispatchThunkDerivative` and `MethodDescriptorDerivative` as link entities. The derivative functions of initializers, subscripts, properties, and methods are **all methods**, so we don't need other link entities for this purpose. - Mangle dispatch thunks and method descriptors. Make `AutoDiffFunction` a context node since it can be nested. Resolves SR-13866 (rdar://71318828) and SR-13125 (rdar://65240599).
|
@swift-ci please test and merge |
This was referenced Jan 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DispatchThunkDerivativeandMethodDescriptorDerivativeas link entities. The derivative functions of initializers, subscripts, properties, and methods are all methods, so we don't need other link entities for this purpose.AutoDiffFunctiona context node since it can be nested.Resolves SR-13866 (rdar://71318828) and SR-13125 (rdar://65240599).