Skip to content

stdlib: remove Boolean protocol #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 18, 2016
Merged

stdlib: remove Boolean protocol #3567

merged 9 commits into from
Jul 18, 2016

Conversation

gribozavr
Copy link
Contributor

Per SE-0109.

Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr
Copy link
Contributor Author

@swift-ci Please test

@lattner
Copy link
Contributor

lattner commented Jul 18, 2016

Thanks Dmitri, but I was already working on this, and it just landed.

@gribozavr
Copy link
Contributor Author

@lattner No problem, but this PR also removes the Bool.boolValue API, which we don't need anymore. I'll refresh the PR.

@lattner
Copy link
Contributor

lattner commented Jul 18, 2016

I'm pretty sure that I removed Bool.boolValue, but please feel free to clean up anything you think should be improved.

@gribozavr
Copy link
Contributor Author

@lattner It is still referenced in validation-test/stdlib/FixedPoint.swift.gyb for example, and other places.

@gribozavr gribozavr force-pushed the stdlib-remove-boolean branch 2 times, most recently from 2fc7648 to a78f25f Compare July 18, 2016 05:51
@lattner
Copy link
Contributor

lattner commented Jul 18, 2016

I just removed that as part of fixing the validation tests.

@gribozavr
Copy link
Contributor Author

@lattner I see now. OK, I call this PR a grab bag of cleanups then.

@lattner
Copy link
Contributor

lattner commented Jul 18, 2016

SGTM, thanks! Sorry for stepping on your toes. I'm done touching bool stuff. :-)

@gribozavr gribozavr force-pushed the stdlib-remove-boolean branch 3 times, most recently from ca445cd to 7612728 Compare July 18, 2016 08:07
@gribozavr
Copy link
Contributor Author

@swift-ci Please test OS X platform

@gribozavr
Copy link
Contributor Author

@swift-ci Please smoke test OS X platform

@gribozavr gribozavr force-pushed the stdlib-remove-boolean branch from 7612728 to e72bece Compare July 18, 2016 09:41
@gribozavr
Copy link
Contributor Author

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 103b6b8 into master Jul 18, 2016
@gribozavr gribozavr deleted the stdlib-remove-boolean branch July 19, 2016 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gribozavr @lattner @swift-ci