Skip to content

[Concurrency] Task can have instances, add UnsafeCurrentTask; remove any Time related API #35704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2021

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Feb 2, 2021

  • removes anything Deadline related
    • we're not reviewing those just yet, and for time we'll need to do some more work to be ready here
  • enum Task -> struct Task
  • use CurrentUnsafeTask as the core of all things
  • adds more and better tasks to Task.priority since the existing test didn't really do much

@ktoso ktoso force-pushed the wip-tasks-rev3 branch 4 times, most recently from 3f721b4 to 4ed8283 Compare February 3, 2021 04:43
@ktoso ktoso marked this pull request as draft February 3, 2021 04:45
@ktoso ktoso force-pushed the wip-tasks-rev3 branch 7 times, most recently from 1cb36f6 to 650389d Compare February 3, 2021 07:40
@ktoso
Copy link
Contributor Author

ktoso commented Feb 11, 2021

Will do, thanks Doug!

@ktoso ktoso marked this pull request as ready for review February 11, 2021 05:20
@ktoso
Copy link
Contributor Author

ktoso commented Feb 11, 2021

@swift-ci please smoke test

- introduce UnsafeCurrentTask
- implement Hashable, Equatable on tasks
- assume we'll have a way to get a task from sync context
- Task.Handle now has a Failure type as well
- Task.Handle.getResult
@ktoso ktoso force-pushed the wip-tasks-rev3 branch 2 times, most recently from fa9abb0 to 83b8e1d Compare February 12, 2021 04:07
@ktoso
Copy link
Contributor Author

ktoso commented Feb 12, 2021

@swift-ci please smoke test and merge

@ktoso
Copy link
Contributor Author

ktoso commented Feb 12, 2021

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit dd06281 into swiftlang:main Feb 12, 2021
@ktoso ktoso deleted the wip-tasks-rev3 branch February 12, 2021 10:31
@compnerd
Copy link
Member

This seems to have broken the Windows CI. @shahmishal - seems that the Windows tests didn't trigger here?

@compnerd
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants