[sil-combine] Fix optimization of COWBufferRead for ownership #35721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… IntPtrOperand as a value, not a const ref. 1. The reason to do this is that an InteriorPointerOperand is a value type. 2. Sometimes one wants to be able to use the IntPtrOperand that is not a const & and the value type formulation always works. Functionality wise, this is NFCI.
I was able to use the interior pointer operand API to great effect here.
|
@swift-ci smoke test |
|
@gottesmm post-commit review: Please also check in your tests that the builtin can be removed completely. |
|
Ok. I will fix. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got to use the interior pointer functionality to simplify the algorithm/make it safer.