[libSyntax] Store the token's text in the SyntaxArena #35733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
raw-syntax-text-storage
branch
from
8be3707 to
8355d88
Compare
ahoppen
force-pushed
the
raw-syntax-text-storage
branch
3 times, most recently
from
748ca47 to
2509f59
Compare
|
@swift-ci Please test |
3 tasks
|
Ah sorry wrong PR |
Do the same thing that we are already doing for trivia: Since RawSyntax nodes always live inside a SyntaxArena, we don't need to tail-allocate an OwnedString to store the token's text. Instead we can just copy it to the SyntaxArena. If we copy the entire source buffer to the syntax arena at the start of parsing, this means that no more copies are required later on. Plus we also avoid ref-counting the OwnedString which should also increase performance.
This decreases the size of RawSyntax nodes from 88 to 64 bytes by - Avoiding some padding by moving RefCount further up - Limiting the length of tokens and their trivia to 32 bits. We would hit this limit with files >4GB but we also hit this limit at other places like the TextLength property in the Common bits.
ahoppen
force-pushed
the
raw-syntax-text-storage
branch
from
2509f59 to
c1d65de
Compare
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits from #35649
Do the same thing that we are already doing for trivia: Since
RawSyntaxnodes always live inside aSyntaxArena, we don't need to tail-allocate anOwnedStringto store the token's text. Instead we can just copy it to theSyntaxArena. If we copy the entire source buffer to the syntax arena at the start of parsing, this means that no more copies are required later on. Plus we also avoid ref-counting theOwnedStringwhich should also increase performance.Performance checklist (performed on my local machine)