Skip to content

[WIP] [stdlib] [SE-0089] Rename String.init(_:) #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

moiseev
Copy link
Contributor

@moiseev moiseev commented Jul 18, 2016

What's in this pull request?

Continuation of the work started by @frootloops in #3212.
PR comments have been addressed.

More work needs to be performed to update all the tests to use the new String.init(describing:) instead of String.init(_:).

Besides, as UnicodeScalar.description has been changed to return the integer value of a code point, StaticString now behaves in a weird way. Here is the example of this behavior from the REPL:

(swift) let us: UnicodeScalar = "a"; us.description
// us : UnicodeScalar = "97"
// r0 : String = "5755"

Resolved bug number: (SR-1881)


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

/// For example, the integer value 1050 can be represented in its entirety as
/// the string "1050".
///
/// The description property of a conforming type must be a value-preserving
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about description?

@gribozavr
Copy link
Contributor

Continuing in #3761.

@gribozavr gribozavr closed this Jul 27, 2016
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants