Fold Incremental External Dependency Nodes Into External Dependency Nodes #35741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes Remove this distinction without a difference. Originally, the thought was to 1) Isolate the cross-module build infrastructure 2) Provide a signal to the driver that a dependency had swiftdeps info in it But the driver need only notice swiftmodule files as external dependencies and try to extract that information if it can to divine the signal it needs. Additionally, we can give it fingerprints as priors to let it know there might be incremental info to be had.
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux |
|
@swift-ci build toolchain |
|
@swift-ci smoke test macOS |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
@swift-ci smoke test macOS |
|
@CodaFi macOS build toolchain PR bot failed due to this error: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove this distinction without a difference. Originally, the thought
was to
But the driver need only notice swiftmodule files as external
dependencies and try to extract that information if it can to divine the
signal it needs. Additionally, we can give it fingerprints as priors to
let it know there might be incremental info to be had.