[test] Mark these tests unsupported like Linux. #35759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, even with Dispatch running on Linux, these tests are unsupported on those platforms. These also fail on OpenBSD, so presumably these should be marked unsupported on this platform too.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Feb 5, 2021
The pr swiftlang#35755 changed these tests from `REQUIRES: OS=macosx` to using `XFAIL: linux`, which suggests other platforms supporting concurrency must affirmatively mark these failing tests XFAIL as well. This is distinct from swiftlang#35759, since ideally that pr will be cherrypicked over to the 5.4 branch and including these changes there would cause a prospective cherrypick to diverge.
finagolfin
approved these changes
Feb 6, 2021
|
LGTM, although I can't recall why these failed in the first place (or what would be necessary to enable them on non-Darwin platforms). |
|
ping. Is there anything left to get this merged? |
|
@varungandhi-apple, mind merging when you get a chance? |
|
@swift-ci smoke test and merge |
|
MacOS CI failure is unrelated. |
|
Can you please retry the smoke test and merge? Thanks. |
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, even with Dispatch running on Linux, these tests are
unsupported on those platforms. These also fail on OpenBSD, so
presumably these should be marked unsupported on this platform too.