GSB: Optimize PotentialArchetype::getDependentType() #35773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were spending a lot of time in DependentMemberType::get(), via PotentialArchetype::getDependentType(), which is a recursive walk from the root to the leaf. We can reduce this cost with two changes:
PotentialArchetype *
at all, only aType
.GenericParamKey
withAssociatedTypeDecl *
.We still have to rebuild
DependentMemberType
to "re-sugar" them with the right generic parameter name. While this is important when the type is ultimately meant for user consumption, there are many places where we do it unnecessarily. Fixing those is the next step here.On this incredibly silly benchmark, an asserts build is now twice as fast as without this change, from ~8 seconds to 4: