SILOptimizer: allow function pointers in static globals and static global arrays. #35780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
force-pushed
the
static-function-arrays
branch
from
4f058ba to
279c1b9
Compare
eeckstein
force-pushed
the
static-function-arrays
branch
from
279c1b9 to
b00399d
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
eeckstein
force-pushed
the
static-function-arrays
branch
2 times, most recently
from
92771d2 to
383f8f6
Compare
|
@swift-ci test |
|
@swift-ci benchmark |
|
Build failed |
Performance: -O
Code size: -O
Performance: -Osize
Code size: -Osize
Performance: -OnoneCode size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
|
@swift-ci test linux |
|
Build failed |
|
@swift-ci test macOS |
|
Build failed |
eeckstein
force-pushed
the
static-function-arrays
branch
from
383f8f6 to
2cb0cf9
Compare
|
@swift-ci test |
|
Build failed |
If we know that we have a FunctionRefInst (and not another variant of FunctionRefBaseInst), we know that getting the referenced function will not be null (in contrast to FunctionRefBaseInst::getReferencedFunctionOrNull). NFC
…uctions in an initializer of a SILGlobalVariable. This means: don't require to have a SILFunction in the SILBuilder.
It makes sense to to this in a single pass, because there might be dead cycles for globals and functions, e.g. if a global references a function in its static initializer and the function references that global. Another improvement: eliminate dead global-initializers. Before we had an explicit SIL representation of statically initialized globals, we had to keep them alive. rdar://32956923
The main change is to rename DeadFunctionElimination -> DeadFunctionAndGlobalElimination, because the pass is now also doing dead-global elimination. A second change is to remove the FunctionLivenessComputation base class. It’s not used anywhere else.
…in global variables. We cannot replace a load from a global let-variable with a function_ref, if the referenced function would violate the resilience rules. That means if a non-public function_ref would be inlined into a function which is serialized.
Just moving a few functions around and make emitConstantValue the main entry point for creating constants. NFC
…obal arrays.
For example, generate a static global for the array literal in:
func foo(_ i: Int) -> Int { ... }
func bar(_ i: Int) -> Int { ... }
func returnFunctionArray() -> [(Int) -> Int] {
return [foo, bar]
}
rdar://73570149
https://bugs.swift.org/browse/SR-14101
eeckstein
force-pushed
the
static-function-arrays
branch
from
2cb0cf9 to
0a483a6
Compare
|
@swift-ci test |
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Feb 16, 2021
In case a function is only referenced from a global without a declaration (e.g. an outlined global), we could end up with a null IRGenModule for the function (with multithreaded compilation). In this case, just use the primary IGM. This fixes a IRGen crash, introduced with swiftlang#35780 rdar://74358251
eeckstein
added a commit
to eeckstein/swift
that referenced
this pull request
Feb 16, 2021
…lobals. This fixes a IRGen crash, introduced with swiftlang#35780 rdar://74358259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, generate a static global for the array literal in:
rdar://73570149
https://bugs.swift.org/browse/SR-14101
This PR also contains an improvement of DeadFunctionElimination: it now can also remove dead global variables.
Handling function references in global initializers is required in DeadFunctionElimination anyway. It was only a small addition to implement dead global variable elimination in the same change.
rdar://32956923