Fix crash in merge-modules involving a file with extension of nested type #35809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type rdar://74062542
|
@swift-ci smoke test |
|
@swift-ci Please test Windows platform |
CodaFi
reviewed
Feb 8, 2021
| static TypeDecl * | ||
| findNestedTypeDeclInModule(ModuleDecl *extensionModule, | ||
| Identifier name, NominalTypeDecl *parent) { | ||
| return findNestedTypeDeclInModule(nullptr, extensionModule, name, parent); |
There was a problem hiding this comment.
This makes me nervous since we can now set up a cross-ref that causes resolution to re-enter itself - especially through a name lookup. This was the cause of a ton of circular lookup problems in the SDK when we were refactoring the clang importer. Lazy member loading no longer has re-entrancy guards in it to catch this too...
There was a problem hiding this comment.
Wouldn't a circular issue be detected in the frontend invocations before reaching merge-modules?
But regardless, it looks to me that this particular code-path follows the strict xref path components, so it's going to reach the end of the lookup by definition.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://74062542