[validation] Fix some portability test issues. #35810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we fix a few portability issues affecting running the validation tests on OpenBSD. The remaining failures will be dealt with separately. 1. In the `rth` tool, ensure `-z origin` is specified to the linker when using `$ORIGIN`, as required on this platform. 2. Explicitly set the rpath in the `dsohandle-multi-module` execution test, since the test uses built dynamic libraries during the test. 3. Erase the environment variable instead of using `env -u`, the latter of which is not portable.
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we fix a few portability issues affecting running the validation tests on OpenBSD. The remaining failures will be dealt with separately.
In the
rthtool, ensure-z originis specified to the linker whenusing
$ORIGIN, as required on this platform.Explicitly set the rpath in the
dsohandle-multi-moduleexecutiontest, since the test uses built dynamic libraries during the test.
Erase the environment variable instead of using
env -u, the latterof which is not portable.