[AutoDiff] Add '@differentiable(reverse)'. #35811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Update all the call sites. |
dan-zheng
approved these changes
Feb 7, 2021
rxwei
changed the title
rxwei
force-pushed
the
69980056-differentiable-reverse
branch
from
96e4059 to
283b3d2
Compare
rxwei
force-pushed
the
69980056-differentiable-reverse
branch
from
283b3d2 to
f8ba991
Compare
rxwei
changed the title
rxwei
force-pushed
the
69980056-differentiable-reverse
branch
from
f8ba991 to
d457cb7
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
rxwei
force-pushed
the
69980056-differentiable-reverse
branch
2 times, most recently
from
624a6d4 to
f2baf57
Compare
Compiler: - Add `Forward` and `Reverse` to `DifferentiabilityKind`. - Expand `DifferentiabilityMask` in `ExtInfo` to 3 bits so that it now holds all 4 cases of `DifferentiabilityKind`. - Parse `@differentiable(reverse)` and `@differentiable(_forward)` declaration attributes and type attributes. - Emit a warning for `@differentiable` without `reverse`. - Emit an error for `@differentiable(_forward)`. - Rename `@differentiable(linear)` to `@differentiable(_linear)`. - Make `@differentiable(reverse)` type lowering go through today's `@differentiable` code path. We will specialize it to reverse-mode in a follow-up patch. ABI: - Add `Forward` and `Reverse` to `FunctionMetadataDifferentiabilityKind`. - Extend `TargetFunctionTypeFlags` by 1 bit to store the highest bit of differentiability kind (linear). Note that there is a 2-bit gap in `DifferentiabilityMask` which is reserved for `AsyncMask` and `ConcurrentMask`; `AsyncMask` is ABI-stable so we cannot change that. _Differentiation module: - Replace all occurrences of `@differentiable` with `@differentiable(reverse)`. - Delete `_transpose(of:)`. Resolves rdar://69980056.
rxwei
force-pushed
the
69980056-differentiable-reverse
branch
from
f2baf57 to
af8942d
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci please test and merge |
|
@swift-ci please test macOS |
rxwei
added a commit
to rxwei/swift-syntax
that referenced
this pull request
Feb 8, 2021
…bute. Reflects changes in swiftlang/swift#35811 (rdar://69980056).
|
swiftlang/swift-syntax#258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler:
ForwardandReversetoDifferentiabilityKind.DifferentiabilityMaskinExtInfoto 3 bits so that it now holds all 4 cases ofDifferentiabilityKind.@differentiable(reverse)and@differentiable(_forward)declaration attributes and type attributes.@differentiablewithoutreverse.@differentiable(_forward).@differentiable(linear)to@differentiable(_linear).@differentiable(reverse)type lowering go through today's@differentiablecode path. We will specialize it to reverse-mode in a follow-up patch.ABI:
ForwardandReversetoFunctionMetadataDifferentiabilityKind.TargetFunctionTypeFlagsby 1 bit to store the highest bit of differentiability kind (linear). Note that there is a 2-bit gap inDifferentiabilityMaskwhich is reserved forAsyncMaskandConcurrentMask;AsyncMaskis ABI-stable so we cannot change that._Differentiation module:
@differentiablewith@differentiable(reverse)._transpose(of:).Resolves rdar://69980056.