Fix a couple of crash-on-invalid situations with local variables defined inside result builders #35812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would previously reject properties without an initializer expression, but this is not quite sufficient, because of 'lazy', property wrappers, and observers. We could probably support all three in result builder contexts, but for now, let's diagnose them like other computed properties, instead of crashing. Fixes part of <rdar://problem/73545981>.
Fixes <rdar://problem/73545981>.
slavapestov
force-pushed
the
result-builder-invalid-var-crash
branch
from
b560fed to
6714723
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
DougGregor
reviewed
Feb 9, 2021
| } | ||
|
|
||
| // Also check for invalid attributes. | ||
| TypeChecker::checkDeclAttributes(var); |
There was a problem hiding this comment.
Whoops, this is a really important one. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declarations inside result builders don't go via the usual
typeCheckDecl()code path. Most are simply rejected, but local variables are allowed. We were missing some validation checks:Fixes rdar://problem/73545981.