In backwards compatibility mode, be more permissive of Obj-C nulls #35825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erences The new cast logic checks and aborts if a non-nullable pointer has a null value at runtime. However, because this was tolerated by the old casting logic, some apps inadvertently rely on being able to cast such null references. This change adds specific checks for null pointers in compatibility mode and handles them similarly to the previous casting logic: * Casting to Obj-C or CF type: casting a null pointer succeeds * Casting to class-constrained existential: casting a null pointer succeeds * Casting to a Swift class type: cast fails without crashing * Bridging from Obj-C class to Swift struct type: cast fails without crashing This also adds a guard to avoid trying to lookup the dynamic type of a null class reference. In non-compatibility mode, all of the above cause an immediate runtime crash. The changes here are only intended to support existing binaries running against new Swift runtimes. Resolves rdar://72323929
|
@swift-ci Please test |
|
@swift-ci Please test Windows platform |
mikeash
approved these changes
Feb 9, 2021
tbkka
added a commit
to tbkka/swift
that referenced
this pull request
Feb 9, 2021
…ll references (swiftlang#35825) (This cherry-picks swiftlang#35825 from main to release/5.4) The new cast logic checks and aborts if a non-nullable pointer has a null value at runtime. However, because this was tolerated by the old casting logic, some apps inadvertently rely on being able to cast such null references. This change adds specific checks for null pointers in compatibility mode and handles them similarly to the previous casting logic: * Casting to Obj-C or CF type: casting a null pointer succeeds * Casting to class-constrained existential: casting a null pointer succeeds * Casting to a Swift class type: cast fails without crashing * Bridging from Obj-C class to Swift struct type: cast fails without crashing This also adds a guard to avoid trying to lookup the dynamic type of a null class reference. In non-compatibility mode, all of the above cause an immediate runtime crash. The changes here are only intended to support existing binaries running against new Swift runtimes. Resolves rdar://72323929
tkremenek
added a commit
that referenced
this pull request
Feb 9, 2021
…ling54 [5.4] In backwards compatibility mode, be more permissive of Obj-C nulls (#35825)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new cast logic checks and aborts if a non-nullable pointer has a null value
at runtime. However, because this was tolerated by the old casting logic, some
apps inadvertently rely on being able to cast such null references.
This change adds specific checks for null pointers in compatibility mode and
handles them similarly to the previous casting logic:
This also adds a guard to avoid trying to lookup the dynamic type of a null
class reference.
In non-compatibility mode, all of the above cause an immediate runtime crash.
The changes here are only intended to support existing binaries running against
new Swift runtimes.
Resolves rdar://72323929