Skip to content

Sema: Fix enum case witness crash when the requirement does not specify accessors #35860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 3, 2021
Merged

Sema: Fix enum case witness crash when the requirement does not specify accessors #35860

merged 3 commits into from
Nov 3, 2021

Conversation

AnthonyLatsis
Copy link
Collaborator

We were checking only for a parsed setter.

slavapestov
slavapestov reviewed Feb 9, 2021
View reviewed changes
@AnthonyLatsis AnthonyLatsis force-pushed the enum-witness-no-accessor-req branch 2 times, most recently from da7d4bb to e2faabc Compare February 10, 2021 14:55
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test macOS

@AnthonyLatsis AnthonyLatsis force-pushed the enum-witness-no-accessor-req branch from e2faabc to 35a829a Compare November 2, 2021 11:38
@AnthonyLatsis
Copy link
Collaborator Author

@slavapestov Could you take another look at this? The idea is that we care only about what isSettable has to say, and StorageImplInfoRequest now handles protocol requirements as not specifying a setter by default, so the conformance succeeds and we no longer get a confusing error telling us that the protocol requires something to be settable when there isn't a parsed setter.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please clean smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci Please clean smoke test macOS

@AnthonyLatsis
Copy link
Collaborator Author

Thank you!

@AnthonyLatsis AnthonyLatsis merged commit dd984b1 into swiftlang:main Nov 3, 2021
@AnthonyLatsis AnthonyLatsis deleted the enum-witness-no-accessor-req branch November 3, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavapestov slavapestov slavapestov approved these changes

@theblixguy theblixguy Awaiting requested review from theblixguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyLatsis @slavapestov