Skip to content

[utils] split-cmdline: Handle typical compiler invocations better #35888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

lorentey
Copy link
Member

Add a general heuristic that options ending in -path expect an argument.

Remove such options from the explicit is_arg_param list and sort it to simplify maintenance.

Recognize -target-sdk-version.

Add a general heuristic that options ending in -path expect an argument.

Remove such options from the explicit is_arg_param list and sort it to simplify maintenance.

Recognize -target-sdk-version.
@lorentey
Copy link
Member Author

@swift-ci smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lorentey lorentey merged commit 37d52fb into swiftlang:main Feb 16, 2021
@lorentey lorentey deleted the split-cmdline-improvements branch February 16, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants