don't crash the symbol graph tool when a module fails to load #35923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
bitjammer
approved these changes
Feb 12, 2021
QuietMisdreavus
deleted the
QuietMisdreavus/dont-crash-on-failed-loads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the symbol graph tool fails to load a module, it currently crashes upon trying to load the main-file name. This PR adds a check before loading symbols to ensure that the module loaded properly; if it failed to load, the tool now prints an error message and cleanly exits instead of hitting an assertion and crashing.
Fixes rdar://74239464