[android] Fix path to ICU libraries and target name in Android docs #35949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point `ARM_DIR` to the output directory containing the libraries.
fwcd
force-pushed
the
android-lib-path
branch
from
733a363 to
1f4eabc
Compare
The target arch name used here is `armv7` rather than `armv7a`.
fwcd
changed the title
finagolfin
approved these changes
Jun 13, 2021
|
@CodaFi, mind getting this small doc pull in? |
|
Yeah, LGTM @swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point
ARM_DIRto the correct output directory containing the built libraries (libicuucswift.so,libicui18nswift.so, etc).Also use
armv7-unknown-linux-androideabi21instead ofarmv7a-unknown-linux-androideabi21as a target, since the compiler will otherwise throw an error: