[concurrency] allow 'get' access to properties from outside the actor #35965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
force-pushed
the
actor-effectful-properties
branch
6 times, most recently
from
420aa0c to
59f8462
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
actor-effectful-properties
branch
4 times, most recently
from
125f876 to
7c8030c
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows Platform |
kavon
force-pushed
the
actor-effectful-properties
branch
8 times, most recently
from
33dabd5 to
7fdb0b2
Compare
|
@swift-ci please smoke test |
kavon
force-pushed
the
actor-effectful-properties
branch
from
7fdb0b2 to
83b88c2
Compare
kavon
commented
Mar 4, 2021
ktoso
approved these changes
Mar 4, 2021
kavon
force-pushed
the
actor-effectful-properties
branch
from
83b88c2 to
3fd3ba5
Compare
|
@swift-ci please smoke test |
The design of things are currently a bit in flux, so until that settles down, I thought it would be better to just log this as a possible clean-up in the future.
kavon
force-pushed
the
actor-effectful-properties
branch
from
3fd3ba5 to
d67c50c
Compare
kavon
force-pushed
the
actor-effectful-properties
branch
from
d67c50c to
0f10638
Compare
We now mark some DeclRefExpr and LookupExprs as implicitly async during typechecking, depending on whether they appear in a context that is only performing a read / get operation, and whether they are cross-actor operations. also resolves rdar://72403401 by improving the error messages (no more vague "'await' in async context" when its clearly a call!)
…not made it to SILGen For the dynamic versions of LookupExprs, we do not expect these to be implicitly async. For the other cases, I simply haven't implemented them yet.
The strategy for implementing them is integrated with the PathComponent infrastructure in SILGen in order to correctly support mixtures of chained accesses and forced optionals, etc. The actor isolation information is only piped into LValues from the expressions that might be marked implicitly-async.
kavon
force-pushed
the
actor-effectful-properties
branch
from
0f10638 to
de0d998
Compare
|
@swift-ci please smoke test and merge |
DougGregor
reviewed
Mar 5, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves rdar://74199653
TODOs:
'async' in a function that does not support concurrency(rdar://72403401)Make sure we disallow read accesses to subscripts that take anTurns out we don't allowinoutargument.inouton subscript parameters in general._modifyand_readaccessors.Something to fix in a later PR: