Skip to content

CSE OSSA: Enable lookThroughOwnershipInsts for some more instructions #35979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2021
Merged

CSE OSSA: Enable lookThroughOwnershipInsts for some more instructions #35979

merged 1 commit into from
Feb 16, 2021

Conversation

meg-gupta
Copy link
Contributor

No description provided.

@meg-gupta
Copy link
Contributor Author

Still trying to repro - rdar://74359921. But not looking through ownership instructions in these cases can cause the llvm::DenseMapInfo<SimpleValue>::getHashValue return different hashes but llvm::DenseMapInfo<SimpleValue>::isEqual return true. This inconsistency can cause an assert fire in ScopedHashTable::grow

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta
Copy link
Contributor Author

I am going to merge this. Working on refactoring CSE to filter operands based on ownership constraints while computing hashes.

@meg-gupta meg-gupta merged commit 222a988 into swiftlang:main Feb 16, 2021
@slavapestov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meg-gupta @slavapestov